fix: improve project favicon detection for monorepos by ponbac · Pull Request #1024 · pingdotgg/t3code

ponbac · 2026-03-13T13:43:39Z

The XXL tag seems a little weird for this PR? It is a net +288 LoC, excluding test files.

What Changed

Improve project favicon detection without introducing a broad recursive search.
Closes #1020.

Rules, in order:

Check well-known favicon paths in the requested project root.
Example: /repo/favicon.svg or /repo/public/favicon.ico.
If none exist, look for <link rel="icon" ... href="..."> tags or object-style { href, rel: "icon" } declarations in a small set of common source files, then resolve that target.
Example: /repo/index.html points to /brand/logo.svg, so the route first tries /repo/public/brand/logo.svg and then /repo/brand/logo.svg.
If still nothing is found, repeat the same checks for first-level children of apps/ and packages/, plus other top-level directories in the requested root, using the same non-git directory ignore rules as workspaceEntries.
Example: /repo/apps/web/public/favicon.png or /repo/frontend/public/favicon.png is found when the cwd is /repo.
Prefer a root match over nested workspace matches.
Example: /repo/favicon.svg wins over /repo/apps/web/public/favicon.ico.
Fall back to the existing generated SVG when nothing is found.

I also extracted the shared gitignore probing into apps/server/src/gitIgnore.ts so both workspaceEntries and projectFaviconRoute use the same chunked git check-ignore --no-index -z --stdin filtering. I also extracted the shared workspace directory ignore policy into apps/server/src/workspaceIgnore.ts, so projectFaviconRoute now uses the same non-git skip rules as workspaceEntries when scanning nested roots instead of keeping a separate ignore list.

Why

The current behavior misses common monorepo layouts where the favicon lives under an app directory instead of the repo root.

There was already an earlier PR for this in the upstream repo: #690. That version was larger and messier. This keeps the rules simple on purpose, leaving more extensive changes to project icons for trusted maintainers.

UI Changes

Not applicable.

Checklist

This PR is small and focused
I explained what changed and why
I included before/after screenshots for any UI changes
I included a video for animation/interaction changes

Note

Improve project favicon detection to support monorepos with git-ignore filtering

Rewrites tryHandleProjectFaviconRequest in projectFaviconRoute.ts as an Effect-based handler that searches the project root, then conventional monorepo subdirectories (apps/, packages/), then other top-level directories, before falling back to an SVG placeholder.
Adds gitIgnore.ts with filterGitIgnoredPaths (chunked git check-ignore invocations) and isInsideGitWorkTree, used to skip git-ignored favicon candidates and source files.
Extracts workspace directory ignore rules into a dedicated workspaceIgnore.ts module and refactors workspaceEntries.ts to import shared git helpers from gitIgnore.
All path resolution is secured by realpath and project-root containment checks; unreadable files and git errors are treated as misses (fail-open).
Behavioral Change: the favicon route now runs as an Effect requiring FileSystem, provided via provideService in wsServer.ts.

^{Macroscope summarized ea10d7f.}

Note

Medium Risk
Moderate risk: rewrites the favicon HTTP route to new Effect-based filesystem and git-aware search logic, which could change responses/perf and has more path-handling edge cases despite added containment checks and tests.

Overview
Improves /api/project-favicon resolution to support monorepo layouts by searching the requested root first, then scanning likely child app/package directories and parsing a small set of source files for rel=icon metadata before falling back to the generated SVG.

Adds shared gitIgnore utilities (isInsideGitWorkTree, chunked filterGitIgnoredPaths, splitNullSeparatedPaths) and applies gitignore/workspace-directory ignore filtering to favicon candidate paths, source probes, and nested search roots (including caching of gitignore decisions).

Refactors workspaceEntries to consume the new shared gitIgnore + workspaceIgnore modules, and updates wsServer/tests to call the favicon handler as an Effect (with FileSystem provided) while expanding route test coverage for ordering, unreadable files, and gitignored paths.

^{Written by Cursor Bugbot for commit ea10d7f. This will update automatically on new commits. Configure here.}

coderabbitai · 2026-03-13T13:43:53Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 57a40595-fb78-4b1c-948f-f0fe42eb7813

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a4a8d330eb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

apps/server/src/projectFaviconRoute.ts

eddieajau · 2026-03-14T10:20:10Z

My 2c

getIgnore.ts should be separated into individual commands for isInsideGitWorkTree, filterGitIgnoredPaths. You've done the right think pulling it out, but it could go further.

I would add unit tests for this file rather than relying on integration tests.

Since this is a new file, I would also add some solid docblocks to provide good human and AI context for the decisions being made. Hopefully the reviewers will pick that up and think it's a good idea for their code standards.

ponbac · 2026-03-14T16:43:43Z

My 2c

getIgnore.ts should be separated into individual commands for isInsideGitWorkTree, filterGitIgnoredPaths. You've done the right think pulling it out, but it could go further.

I would add unit tests for this file rather than relying on integration tests.

Since this is a new file, I would also add some solid docblocks to provide good human and AI context for the decisions being made. Hopefully the reviewers will pick that up and think it's a good idea for their code standards.

Not sure about separating them right now, but I also feel like isInsideGitWorkTree() should live somewhere else. It does not really have anything to do with .gitignore.

I agree with the unit tests, added now.

Also added an explanatory comment to the filterGitIgnoredPaths(). I should maybe add additional ones, but I am not sure what is preferred here.

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

apps/server/src/gitIgnore.ts

github-actions bot added size:XL 500-999 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Mar 13, 2026

ponbac force-pushed the favicon-recursive branch 2 times, most recently from 30cac2c to b936f17 Compare March 13, 2026 13:47

chatgpt-codex-connector bot reviewed Mar 13, 2026

View reviewed changes

apps/server/src/projectFaviconRoute.ts Outdated Show resolved Hide resolved

ponbac force-pushed the favicon-recursive branch 2 times, most recently from c396c88 to 551d9f2 Compare March 14, 2026 08:09

github-actions bot added size:XXL 1,000+ changed lines (additions + deletions). and removed size:XL 500-999 changed lines (additions + deletions). labels Mar 14, 2026

ponbac force-pushed the favicon-recursive branch 10 times, most recently from a079d93 to 470ab3d Compare March 20, 2026 20:46

ponbac force-pushed the favicon-recursive branch 2 times, most recently from 9f02bfb to 8cc9e19 Compare March 24, 2026 07:11

github-actions bot added size:XL 500-999 changed lines (additions + deletions). and removed size:XXL 1,000+ changed lines (additions + deletions). labels Mar 24, 2026

cursor bot reviewed Mar 24, 2026

View reviewed changes

apps/server/src/gitIgnore.ts Show resolved Hide resolved

ponbac force-pushed the favicon-recursive branch 3 times, most recently from 47c7166 to b41ebd3 Compare March 25, 2026 15:13

ponbac force-pushed the favicon-recursive branch 2 times, most recently from b3c9960 to 185272a Compare March 27, 2026 06:51

ponbac added 2 commits March 28, 2026 07:35

simple favicon detection

148730c

add gitIgnore module tests

ea10d7f

ponbac force-pushed the favicon-recursive branch from 185272a to ea10d7f Compare March 28, 2026 06:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: improve project favicon detection for monorepos#1024

fix: improve project favicon detection for monorepos#1024
ponbac wants to merge 2 commits intopingdotgg:mainfrom
ponbac:favicon-recursive

ponbac commented Mar 13, 2026 •

edited by cursor bot

Loading

Uh oh!

coderabbitai bot commented Mar 13, 2026 •

edited

Loading

Review skipped

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

Uh oh!

eddieajau commented Mar 14, 2026

Uh oh!

ponbac commented Mar 14, 2026 •

edited

Loading

Uh oh!

cursor bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

ponbac commented Mar 13, 2026 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Changed

Why

UI Changes

Checklist

Improve project favicon detection to support monorepos with git-ignore filtering

Uh oh!

coderabbitai bot commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

eddieajau commented Mar 14, 2026

Uh oh!

ponbac commented Mar 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ponbac commented Mar 13, 2026 •

edited by cursor bot

Loading

coderabbitai bot commented Mar 13, 2026 •

edited

Loading

ponbac commented Mar 14, 2026 •

edited

Loading